fix(api-types): Allow empty domain description - #1237
Merged
Conversation
|
🧪 Tempest Identity Compatibility Results (advisory, non-blocking) rust Failed test IDs |
|
🦢 Load Test Results Goose Attack ReportPlan Overview
Request Metrics
Response Time Metrics
Status Code Metrics
Transaction Metrics
Scenario Metrics
Error Metrics
|
|
Bencher Report| Project | keystone |
| Branch | claude/spire-integration-phase-1-y6lzk8 |
| Testbed | ubuntu-latest |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result nanoseconds (ns) (Result Δ%) | Upper Boundary nanoseconds (ns) (Limit %) |
|---|---|---|---|
| Command_Serde/apply/remove | 📈 view plot 🚷 view threshold | 81,867.00 ns(-68.19%)Baseline: 257,357.19 ns | 1,310,034.80 ns (6.25%) |
| Command_Serde/apply/set | 📈 view plot 🚷 view threshold | 87,072.00 ns(-79.13%)Baseline: 417,224.53 ns | 3,208,868.51 ns (2.71%) |
| Command_Serde/pack/delete | 📈 view plot 🚷 view threshold | 124.25 ns(+6.07%)Baseline: 117.14 ns | 154.97 ns (80.18%) |
| Command_Serde/pack/delete_index | 📈 view plot 🚷 view threshold | 107.47 ns(+2.76%)Baseline: 104.59 ns | 137.47 ns (78.18%) |
| Command_Serde/pack/set | 📈 view plot 🚷 view threshold | 212.30 ns(+11.59%)Baseline: 190.25 ns | 246.53 ns (86.11%) |
| Command_Serde/pack/set_index | 📈 view plot 🚷 view threshold | 107.66 ns(+2.96%)Baseline: 104.57 ns | 137.85 ns (78.10%) |
| Command_Serde/unpack/delete | 📈 view plot 🚷 view threshold | 160.41 ns(-14.24%)Baseline: 187.04 ns | 271.28 ns (59.13%) |
| Command_Serde/unpack/delete_index | 📈 view plot 🚷 view threshold | 128.29 ns(-17.68%)Baseline: 155.85 ns | 220.37 ns (58.22%) |
| Command_Serde/unpack/set | 📈 view plot 🚷 view threshold | 246.59 ns(-6.60%)Baseline: 264.00 ns | 366.63 ns (67.26%) |
| Command_Serde/unpack/set_index | 📈 view plot 🚷 view threshold | 125.68 ns(-18.05%)Baseline: 153.36 ns | 214.85 ns (58.50%) |
| Payload_encryption/pack/remove_cmd | 📈 view plot 🚷 view threshold | 112.36 ns(+0.97%)Baseline: 111.28 ns | 150.52 ns (74.65%) |
| Payload_encryption/pack/set_cmd | 📈 view plot 🚷 view threshold | 211.85 ns(+6.53%)Baseline: 198.86 ns | 266.69 ns (79.44%) |
| Payload_encryption/unpack/remove_cmd | 📈 view plot 🚷 view threshold | 158.93 ns(-18.88%)Baseline: 195.92 ns | 285.19 ns (55.73%) |
| Payload_encryption/unpack/set_cmd | 📈 view plot 🚷 view threshold | 246.76 ns(-9.51%)Baseline: 272.70 ns | 381.53 ns (64.68%) |
| Raft_1Node_Latency/prefix/1node | 📈 view plot 🚷 view threshold | 7,704,200.00 ns(+148.30%)Baseline: 3,102,817.80 ns | 7,971,686.42 ns (96.64%) |
| Raft_1Node_Latency/read/1node | 📈 view plot 🚷 view threshold | 31,523.00 ns(-15.22%)Baseline: 37,181.88 ns | 52,084.69 ns (60.52%) |
| Raft_1Node_Latency/remove/1node | 📈 view plot 🚷 view threshold | 254,750.00 ns(-77.90%)Baseline: 1,152,761.72 ns | 11,476,413.61 ns (2.22%) |
| Raft_1Node_Latency/write/1node | 📈 view plot 🚷 view threshold | 265,490.00 ns(-72.35%)Baseline: 960,258.75 ns | 7,538,885.09 ns (3.52%) |
| build_snapshot/default | 📈 view plot 🚷 view threshold | 93,497.00 ns(-23.31%)Baseline: 121,907.67 ns | 266,981.44 ns (35.02%) |
| fernet token/project | 📈 view plot 🚷 view threshold | 1,489.40 ns(+5.12%)Baseline: 1,416.86 ns | 1,820.67 ns (81.81%) |
| get_data_keyspace | 📈 view plot 🚷 view threshold | 0.29 ns(-7.81%)Baseline: 0.31 ns | 0.39 ns (74.24%) |
| get_db | 📈 view plot 🚷 view threshold | 0.29 ns(-8.12%)Baseline: 0.31 ns | 0.39 ns (73.97%) |
| get_fernet_token_timestamp/project | 📈 view plot 🚷 view threshold | 141.47 ns(+1.42%)Baseline: 139.49 ns | 182.00 ns (77.73%) |
| get_keyspace | 📈 view plot 🚷 view threshold | 12.10 ns(+114.67%)Baseline: 5.64 ns | 12.39 ns (97.71%) |
Local, throwaway-VM equivalent of the devstack-full CI job so SPIRE integration / service-auth changes can be iterated on without waiting on CI. Verified end-to-end in a 40G-disk VM: stack.sh brings up mysql/rabbit/nova/cinder/glance/neutron-OVN/SPIRE successfully. cargo build -p uses the Cargo package names (openstack-keystone, openstack-keystone-cli-manage), not the binary names, and the script chowns its DEST dir before devstack's own unprivileged git_clone runs against it. Signed-off-by: Artem Goncharov <artem.goncharov@gmail.com>
description is Option<String>; validator's length(min=1) fired on
Some("") the same as an actual too-short value, rejecting the empty
string devstack sends on its idempotent domain-create/update calls
with a 400. Drop the min bound, keep max=255.
Signed-off-by: Artem Goncharov <artem.goncharov@gmail.com>
gtema
force-pushed
the
claude/spire-integration-phase-1-y6lzk8
branch
from
September 14, 2026 09:47
4ea4de4 to
13d1a03
Compare
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
description is Option; validator's length(min=1) fired on
Some("") the same as an actual too-short value, rejecting the empty
string devstack sends on its idempotent domain-create/update calls
with a 400. Drop the min bound, keep max=255.